Recoded My Website

Garry79

Garry79

Messages
1,270
Name
Garry Ure
Edit My Images
Yes
I've got round to recoding my website and have replaced all tables with divs. Can you guys have a butchers and see if everything looks/works ok?

Cheers

http://www.garryure.co.uk/
 
thats very nice that is Garry. Nice and clean looking, out of interest, have you tried it with a white background?
 
It's very nice.

If you're going on an all-out tidy up though, it might be worth changing any images you're using to display text into actual text. Your logo and "contact", "images" and "blog" don't need to be images, and if images don't load, then you're a bit buggered (as is a screen reader), but that's fairly pedantic!
 
nice look you need to close the box at the bottom though i think it would make it look better boxed off :lol:
 
Cheers guys.

Matty: I have tried it in white but I prefered black. I'm toying with the idea of making the scheme dynamic so the viewer can choose (as a learning curve if nothing else). Quite chuffed as I taught myself all the coding stuff and did it by hand (not the image viewer stuff, that's lightbox V2).

Martyn: The reason the text are images is that using actual text means you are limited by what fonts the viewer has. I know what you're saying though.
 
Its very good Garry. Clean and easy to use. The only problem I can see (and it might be a problem with my server at work) is the image previous to the meercat does not want to load. Otherwise top notch.

Andy
 
Great, it's nice to see people using divs. Just a couple of things though:

You have indented your code a bit, however the <a> tags are at the indent as the parent div. The <a> tags within could benefit from an extra tab

You should seriously consider using an external stylesheet, rather then using inline styling. It makes it much easier to edit in the long run.

Other than those 2 things, very good!
 
MattF said:
Great, it's nice to see people using divs. Just a couple of things though:

You have indented your code a bit, however the <a> tags are at the indent as the parent div. The <a> tags within could benefit from an extra tab

You should seriously consider using an external stylesheet, rather then using inline styling. It makes it much easier to edit in the long run.

Other than those 2 things, very good!
Click to expand...

Cheers mate.

I am using an external .CSS file for the styling (unless I've missed a bit somewhere?).
 
Andysnap said:
Its very good Garry. Clean and easy to use. The only problem I can see (and it might be a problem with my server at work) is the image previous to the meercat does not want to load. Otherwise top notch.

Andy
Click to expand...

Cheers mate, I'll have a look.
 
Garry79 said:
Cheers mate.

I am using an external .CSS file for the styling (unless I've missed a bit somewhere?).
Click to expand...
Well I just saw this:
Code: 
<img style="position:absolute; top:225px; left:10px" src="logo.jpg">
		<img style="position:absolute; top:156px; left:304px" src="line.jpg">
		<img style="position:absolute; top:252px; left:314px" src="images.jpg">
And assumed you weren't using an external sheet. My fault, I should have checked the head section.

On that note of images, well coded XHTML should terminate things like image tags with /> not >.

So for example:

Incorrect
Code: 
<img src="images/photo.jpg" alt="">

Correct
Code: 
<img src="images/photo.jpg alt="" />

I hope I helped there!

Cheers,
Matt
 
I really like it, it's a very clean site that's easy to use, have you considered using a lightbox, i'm sure you will have seen one of these in action if you have a look on the website.

I think this will top your website off if you implement this for when you click on a picture rather than it opening on it's own.
 
MattF said:
..... Good stuff......

Cheers,
Matt
Click to expand...

Cheers mate. Forgot about the image positions, I should really position them as part of the .css too. I'll get it sorted!

Thanks again.
 
martyncoup said:
I really like it, it's a very clean site that's easy to use, have you considered using a lightbox, i'm sure you will have seen one of these in action if you have a look on the website.

I think this will top your website off if you implement this for when you click on a picture rather than it opening on it's own.
Click to expand...

I'm using Lightbox V2 at the moment mate. :thinking:
 
Yeah, I found that if you click an image before they've all loaded then it will open in a new window but then you'd have to have quite a slow connection for the images not to load quickly and also be some sort of frantically impatient photo clicker.
 
martyncoup said:
Yeah all the images had loaded... happened to be on a T1 connection at the time so speed aint an issue.
Click to expand...

Did you have javascript enabled? Seems to work ok for everyone else.
 
lightbox only works when all images are loaded
 
No worries mate!
 
You must log in or register to reply here.
Back
Top